fix: Fix crawler deadlock when API fails during marking request as handled #768
+54
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
t-tooling
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #768 +/- ##
==========================================
+ Coverage 81.91% 82.11% +0.19%
==========================================
Files 46 46
Lines 2693 2695 +2
==========================================
+ Hits 2206 2213 +7
+ Misses 487 482 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Pijukatel
force-pushed
the
fix-rq-state-when-marking-ashandled-fails
branch
from
55bc2a2 to
b4bed05
Compare
vdusek
reviewed
Feb 9, 2026
Comment on lines
-238
to
+239
| except Exception as exc: | ||
| logger.debug(f'Error marking request {request.unique_key} as handled: {exc!s}') | ||
| except Exception: | ||
| logger.exception(f'Error marking request {request.unique_key} as handled.') |
Contributor
There was a problem hiding this comment.
Will logger.exception still include the traceback if we're not using {exc!s}?
Contributor
Author
There was a problem hiding this comment.
Yes, it comes with default exc_info=True
Pijukatel
force-pushed
the
fix-rq-state-when-marking-ashandled-fails
branch
from
b4bed05 to
6db57ef
Compare
…arking request as failed
Pijukatel
force-pushed
the
fix-rq-state-when-marking-ashandled-fails
branch
from
6db57ef to
425093b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
RequestQueueis in an invalid state due to a failed API call to mark the request as handled. This invalid state can lead to a crawler deadlock.ApifyRequestQueueSingleClient, as for the shared client, it is not possible to distinguish between API failure and external modification of the queue on the platform.Issues
Testing
Checklist